-
Notifications
You must be signed in to change notification settings - Fork 106
fix(accordion): fixing header tag, fixing heading text attribute #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, fix issue with headingtext
🦋 Changeset detectedLatest commit: 62750ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
requested changes
Mar 23, 2023
bennypowers
requested changes
Mar 23, 2023
bennypowers
reviewed
Mar 24, 2023
bennypowers
approved these changes
Mar 24, 2023
e4c0fee to
ff8ab75
Compare
bennypowers
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AT passed
Automated testing has passed
demo
Updating demo pages
functionality
Functionality, typically pertaining to the JavaScript.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
anonymousslot checker in thepf-accordion-headercomponent.anonymousslot has been passed in for the headeranonymousslot = we add the header tag to the shadow domanonymousslot = we DO NOT add the header tag to the shadow domheading-textattribute not showing correctly in the header, this has been fixedanonymousslotTesting Instructions
heading-textis showing in the header as expected