Skip to content

Conversation

@brianferry
Copy link
Collaborator

@brianferry brianferry commented Mar 23, 2023

What I did

  1. Added an anonymous slot checker in the pf-accordion-header component.
  • This checks for whether an anonymous slot has been passed in for the header
    • DOES NOT have an anonymous slot = we add the header tag to the shadow dom
    • DOES have an anonymous slot = we DO NOT add the header tag to the shadow dom
  1. We have / had an issue with the heading-text attribute not showing correctly in the header, this has been fixed
  2. Adding a demo to show the attributes being used instead of the anonymous slot

Testing Instructions

  1. DP
  2. Open the developer console and inspect the accordion demos
  3. Verify that the accordion headers with slotted in content do not have nested header tags in the shadow dom
  4. Verify that the accrdion headers in the demo that have text / tags passed in via attributes have the nested header tags in the shadow dom.
  5. Verify that the text passed in through heading-text is showing in the header as expected

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2023

🦋 Changeset detected

Latest commit: 62750ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. AT passed Automated testing has passed labels Mar 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit e6bb9bc
😎 Deploy Preview https://deploy-preview-2435--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@brianferry brianferry requested a review from bennypowers March 23, 2023 18:04
@bennypowers bennypowers enabled auto-merge (squash) March 24, 2023 12:04
@bennypowers bennypowers force-pushed the fix/accordion/heading-header-tag-in-slot branch from e4c0fee to ff8ab75 Compare March 26, 2023 08:31
@bennypowers bennypowers merged commit caabed6 into main Mar 26, 2023
@bennypowers bennypowers deleted the fix/accordion/heading-header-tag-in-slot branch March 26, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants