fix(core): overflow controller scroll on small screens #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c310e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zeroedin
changed the title
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nikkimk
reviewed
Apr 26, 2023
Contributor
nikkimk
left a comment
nikkimk
left a comment
There was a problem hiding this comment.
Looks good, except for that tabs breaks in Safari versions older than 14.
nikkimk
approved these changes
Apr 26, 2023
Contributor
nikkimk
left a comment
nikkimk
left a comment
There was a problem hiding this comment.
TL;DR: LGTM
So the issue I found on Safari is also an issue on https://patternflyelements.org/components/tabs/demo but not on the DP for #2845 .
This tells me that this PR doesn't break Safari and that the other PR should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Testing Instructions
Notes to Reviewers