-
Notifications
You must be signed in to change notification settings - Fork 106
fix(accordion): adding rti for keyboard navigation, removed internal navigation #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix/accordion-rovingtabindex-controller
🦋 Changeset detectedLatest commit: 130cb5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…rdion-rovingtabindex-controller`
…patternfly/patternfly-elements into fix/accordion-rovingtabindex-controller
… fix/accordion-rovingtabindex-controller
bennypowers
requested changes
May 17, 2023
bennypowers
requested changes
May 21, 2023
bennypowers
approved these changes
May 28, 2023
bennypowers
reviewed
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AT passed
Automated testing has passed
functionality
Functionality, typically pertaining to the JavaScript.
ready: code review
Ready for code review!
tests
Related to testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Testing Instructions
1. Go to DP demo page
2. Tab down to the accordion with nested accordions
3. Validate that the instructions located at RedHat-UX/red-hat-design-system#971 work here
Copied below for clarity