Skip to content

Conversation

@brianferry
Copy link
Collaborator

@brianferry brianferry commented May 8, 2023

What I did

  1. Remove the accordion specific keyboard navigation
  2. Add the RTI (Roving Tab Index) controller to accordion after the accordion is initialized
  3. This will fix the arrow up / arrow down issues related to [bug] <rh-accordion> Accessibility: arrow keys inside nested accordions don't work as expected RedHat-UX/red-hat-design-system#971

Testing Instructions

1. Go to DP demo page
2. Tab down to the accordion with nested accordions
3. Validate that the instructions located at RedHat-UX/red-hat-design-system#971 work here

Copied below for clarity

Steps to reproduce

- Run accordion demo locally
- Find nested example
- Expand first accordion item
- Tab inside to the child accordion
- Hit the down arrow (assuming it should go to the next item in the child accordion)
- Focus jumps to the parent accordion header

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

🦋 Changeset detected

Latest commit: 130cb5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@patternfly/pfe-core Patch
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brianferry brianferry requested a review from nikkimk May 8, 2023 13:32
@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 1f602ed
😎 Deploy Preview https://deploy-preview-2493--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label May 8, 2023
@github-actions github-actions bot added the tests Related to testing label May 9, 2023
@brianferry brianferry added the ready: code review Ready for code review! label May 11, 2023
@bennypowers bennypowers enabled auto-merge (squash) May 28, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. ready: code review Ready for code review! tests Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants