Skip to content

feat(label): link variant #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eyevana wants to merge 5 commits into from
Closed

feat(label): link variant #2506

eyevana wants to merge 5 commits into from

Conversation

@eyevana
Copy link
Contributor

@eyevana eyevana commented May 30, 2023

What I did

Testing Instructions

Notes to Reviewers

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 54c55ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass work in progress POC / Not ready for review labels May 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit f8b7d22
😎 Deploy Preview https://deploy-preview-2506--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label May 30, 2023
@bennypowers bennypowers changed the title Feat/label link variant feat(label): link variant May 30, 2023
@bennypowers
Copy link
Member

bennypowers commented Jun 7, 2023 •
edited
Loading

do we want this to go out with 2.2.0?

bennypowers
bennypowers requested changes Jun 7, 2023
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changesets, tests, move link stuff from base to pf-label

@eyevana eyevana closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers requested changes

Assignees

No one assigned

Labels

AT passed Automated testing has passed demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass work in progress POC / Not ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyevana @bennypowers