-
Notifications
You must be signed in to change notification settings - Fork 106
fix(tools): dev server aliased element redirects #2512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0b3c234 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nikkimk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lobsters get terribly mean
What I did
Testing Instructions
.pfe.config.jsonbelow:Notes to Reviewers
Given a
.pfe.conf.jsonwith the following contents:A request to pf-modals demo.css would produce a URL in the dev-server as:
http://localhost:8000/components/magnificent-modal/demo/demo.css
Using deslugify we take the
magnificient-modalslug and check for an alias and return it, If there is no alias we simply return the original path requested ensuring it has the correct tag prefix.http://localhost:8000/components/magnificent-modal/demo/demo.css
Redirects to =>
http://localhost:8000/components/pf-modal/demo/demo.css