-
Notifications
You must be signed in to change notification settings - Fork 106
fix!: v3 deprecations #2655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: v3 deprecations #2655
Conversation
We will retool this and develop something better. In the mean time, use the react wrapper components
🦋 Changeset detectedLatest commit: bbf779e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
"\n## 👕 Commitlint Problems for this PR: \n\n🔎 found 2 errors, 0 warnings\nℹ️ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint\n \n\n\n1eafb022 - Update little-singers-sell.md \n\n\n- ❌ subject may not be empty\n- ❌ type may not be empty " |
6f6c4a2 to
4a54bd0
Compare
ec3a98d to
bd41850
Compare
Use `@patternfly/icons` instead
bd41850 to
6dd5c4f
Compare
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b350e82 to
ec10bac
Compare
ec10bac to
a69f439
Compare
replaces nodeModules: true May break downstream users that depend on `@patternfly/icons`, see `web-dev-server.config.js` Demo files *must* inline their javascript modules BEFORE: ```html <script type="module" src="pf-jazz-hands.js"></script> ``` AFTER: ```html <script type="module"> import '@patternfly/elements/pf-jazz-hands/pf-jazz-hands.js'; </script> ```
|
I apparently fixed the import map generator plugin. I then ran roughshod over the demo files because the import map plugin requires all top-level modules be inlined. I haven't checked yet if this breaks the demos on the DP (eleventy). A followup PR should load those demos in iframes, a la pf.org We'll have to test this with rhds (and maybe cp too, cc @eyevana) this is also missing changesets |
|
Ok this appears to work in rhds with the following dev server config // @ts-check
import { pfeDevServerConfig } from '@patternfly/pfe-tools/dev-server/config.js';
import { glob } from 'glob';
export const litcssOptions = {
include: (/** @type{string[]}*/(/** @type{unknown}*/([
/elements\/rh-[\w-]+\/[\w-]+\.css$/,
/lib\/.*\.css$/,
]))),
exclude: /lightdom/,
};
const libImports =
await glob('./lib/**/*.js', { ignore: ['**/test/**'] })
.then(files => files.map(spec => [`@rhds/elements/${spec}`, `./${spec}`]))
.then(Object.fromEntries);
const elementImports =
await glob('./elements/**/*.js', { ignore: ['**/test/**'] })
.then(files => files.map(spec => [`@rhds/elements/${spec.replace('elements/', '')}`, `./${spec}`]))
.then(Object.fromEntries);
export default pfeDevServerConfig({
litcssOptions,
tsconfig: 'tsconfig.json',
importMapOptions: {
providers: {
'@patternfly/icons': 'nodemodules',
'@patternfly/elements': 'nodemodules',
'@patternfly/pfe-tools': 'nodemodules',
'@patternfly/pfe-core': 'nodemodules',
},
inputMap: {
imports: {
...libImports,
...elementImports,
},
},
},
middleware: [
/** redirect requests for lightdom css to /elements */
function(ctx, next) {
const match = ctx.path.match(/^\/components\/(?<slug>[-\w]+)\/(?<path>.*)\.css$/);
if (match) {
const { slug, path } = /** @type{{ slug: string; path: string }} */ (match.groups);
ctx.redirect(`/elements/rh-${slug}/${path}.css`);
}
return next();
},
/** redirect requests for /assets/* css to /docs/assets/prism.css */
function(ctx, next) {
if (ctx.path.startsWith('/assets/')) {
ctx.redirect(`/docs${ctx.path}`);
}
return next();
}
]
}); |
zeroedin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good. 🔥
Late Guests Timidly Mingle
What I did
Notes to Reviewers
In reviewing this PR, please take a look at the wds config in https://github.com/RedHat-UX/red-hat-design-system/pull/1420/files/7f8e1bc5c1054e55083a0d50582d0bf0a6d56ff4..bfa209ba48e697ad4c78df20d285ff55518a2bbe, as a sample "downstream" usage of these changes