Skip to content

Conversation

@bennypowers
Copy link
Member

@bennypowers bennypowers commented Mar 27, 2024

Lit context provides us with an easier to manage and more robust alternative to the imperative cascades system, let's migrate to that and remove this in PFE 4

What I did

  1. mark @cascades and CascadeController as deprecated

Notes to reviewers:

RHDS uses @cascades in one file:

❯ rg cascades
elements/rh-tabs/rh-tabs.ts
8:import { cascades, deprecation } from '@patternfly/pfe-core/decorators.js';
140:  @cascades('rh-tab')
150:  @cascades('rh-tab', 'rh-tab-panel')
156:  @cascades('rh-tab', 'rh-tab-panel')

which we will remove when we update to TabsController, following PFE 3 release

Lit context provides us with an easier to manage and more robust alternative
to the imperative cascades system, let's migrate to that and remove this in PFE 4
@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: f6ebd9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@patternfly/pfe-core Major
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers
Copy link
Member Author

@Arathy-S does cp elements use this?

@netlify
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit f6ebd9f
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/660461d83689fb00085f9c3e
😎 Deploy Preview https://deploy-preview-2729--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 27, 2024
@bennypowers bennypowers enabled auto-merge (squash) March 27, 2024 12:44
@zeroedin zeroedin self-requested a review March 27, 2024 16:51
Copy link
Contributor

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large granite tower mountains (aka the cascades mountains 🤣 )

@bennypowers bennypowers merged commit 3766961 into main Mar 27, 2024
@bennypowers bennypowers deleted the fix/deprecate-cascades-decorator branch March 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed ready to merge

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants