fix(tabs): roles in sr #2731
Merged
fix(tabs): roles in sr #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 918bc0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
demo
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
force-pushed
the
fix/tabs/role-in-sr
branch
from
af80d22 to
6b3264c
Compare
bennypowers
force-pushed
the
fix/tabs/role-in-sr
branch
from
6b3264c to
e28447f
Compare
zeroedin
approved these changes
Mar 28, 2024
Contributor
zeroedin
left a comment
zeroedin
left a comment
There was a problem hiding this comment.
This looks good to me, will leave it open for @hellogreg to do a run with a screen reader and give final approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
TabsAriaControllerTesting Instructions
<pf-tabs>: roles not being read #2692, see lighthouse results there