Set accordion placeholders fork #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starryeyez024
commented
Mar 14, 2019
| color: var(--pfe-expanded--aux); | ||
| border-left-width: 3px; | ||
| border-left-style: solid; | ||
| border-left-color: var(--pfe-expanded--border-left); |
Member
Author
There was a problem hiding this comment.
i moved these into a mixin instead
| :host([on="dark"]), | ||
| :host([color="darker"]), | ||
| :host([color="darkest"]) { | ||
| @include pfe-trigger-color-darkest; |
Member
Author
There was a problem hiding this comment.
added support for theme colors darker and darkest, color="dark" is not supported
| --pfe-accordion--border-left: 3px solid transparent; | ||
| --pfe-accordion--border-right: 1px solid transparent; | ||
| --pfe-accordion--border-top-bottom: 0px; | ||
| --pfe-accordion--border-focus-color: #{pfe-color(surface--accent)};; |
Member
Author
There was a problem hiding this comment.
idk if accent is a desirable color but i wanted the focus state to be visible whether it was expanded or not
| border: 1px solid transparent; | ||
| font-family: inherit; | ||
| font-size: #{pfe-var(font-size)}; | ||
| font-size: 16px; //calc(#{pfe-var(font-size)} * 1.1); |
Member
Author
There was a problem hiding this comment.
this was the variable it was complaining about, still needs fixing
chrisdo1
reviewed
Mar 14, 2019
| --pfe-accordion--main: #{pfe-color(surface--darkest)}; | ||
| --pfe-accordion--aux: #{pfe-color(surface--darkest--text)}; | ||
| --pfe-accordion--focus: #{pfe-color(surface--darkest--link--focus)}; | ||
| --pfe-accordion--border-left: solid 3px #{pfe-color(surface--darkest--link)}; |
Contributor
There was a problem hiding this comment.
@starryeyez024 One small change: right now the header border is blue on a dark background, it should be white.
starryeyez024
added
the
ready: branch testing
chrisdo1
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.