Skip to content

Upgrade to latest version of storybook #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starryeyez024 merged 17 commits into from
Oct 17, 2019
Merged

Upgrade to latest version of storybook #366

starryeyez024 merged 17 commits into from
Oct 17, 2019

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Mar 15, 2019

A very easy upgrade for a lot of extra features and polish plus the ability to hook into storybook for automated visual regression testing.

@castastrophe castastrophe added feature New feature or request tools Development and build tools labels Mar 15, 2019
@castastrophe castastrophe added ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! labels Mar 22, 2019
@kylebuch8 kylebuch8 self-requested a review April 16, 2019 17:40
@kylebuch8 kylebuch8 self-assigned this Apr 16, 2019
mwcz
mwcz requested changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@mwcz mwcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like light DOM content is being HTML-escaped. Here's an example from pfe-band:

Screenshot from 2019-04-24 15-19-39

mwcz
mwcz previously approved these changes Jun 28, 2019
View reviewed changes
@castastrophe
Copy link
Contributor Author

castastrophe commented Jun 28, 2019

@mwcz I see escape html was added to pfe-card but does it need to be added to any other storybooks?

@castastrophe castastrophe changed the title Upgrade to latest version of storybook WIP: Upgrade to latest version of storybook Jun 28, 2019
@mwcz
Copy link
Contributor

mwcz commented Jun 28, 2019

@castastrophe I'm not entirely sure. I just tested out the branch again and I'm not seeing the same exposed HTML as before. Everything looked good.

@castastrophe
Copy link
Contributor Author

castastrophe commented Jul 26, 2019

@kylebuch8 Is this story still blocked? Do we want to move forward with upgrading storybook or does this need more discussion first?

@castastrophe castastrophe changed the title WIP: Upgrade to latest version of storybook Upgrade to latest version of storybook Jul 26, 2019
@starryeyez024
Copy link
Member

starryeyez024 commented Sep 20, 2019

Noting that this version should add the ability to surface component markdown files in storybook

@starryeyez024
Copy link
Member

starryeyez024 commented Sep 30, 2019

Laughter Goes Through Me!

:D this is awesome!

@castastrophe castastrophe reopened this Oct 1, 2019
@castastrophe
Copy link
Contributor Author

castastrophe commented Oct 1, 2019

@mwcz I think this is ready to merge, if it looks good to you can you approve?

@castastrophe castastrophe added ready to merge and removed ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! labels Oct 1, 2019
@castastrophe
Copy link
Contributor Author

castastrophe commented Oct 17, 2019

@starryeyez024 Resolved the merge conflict w00t

@starryeyez024 starryeyez024 self-requested a review October 17, 2019 19:36
starryeyez024
starryeyez024 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@starryeyez024 starryeyez024 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lakes Great: Trademark (of) Michigan

@starryeyez024 starryeyez024 merged commit 980203b into master Oct 17, 2019
@kylebuch8 kylebuch8 deleted the upgrade-storybook branch October 17, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starryeyez024 starryeyez024 starryeyez024 approved these changes

@mwcz mwcz mwcz left review comments

Assignees

@kylebuch8 kylebuch8

@castastrophe castastrophe

Labels

feature New feature or request ready to merge tools Development and build tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@castastrophe @mwcz @starryeyez024 @kylebuch8