refactor pfe-icon #455
Merged
refactor pfe-icon #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this we'll go with the remote <use> SVG method.
castastrophe
reviewed
Jul 1, 2019
castastrophe
reviewed
Jul 1, 2019
castastrophe
reviewed
Jul 1, 2019
castastrophe
reviewed
Jul 1, 2019
…elements into pfe-icon-refactor
We needed the ability for the component method to not generate content for a tag that doesn't have a slot
…elements into pfe-icon-refactor
This reverts commit 5a47439.
…e v3.14 instead of v3.12
kylebuch8
approved these changes
Aug 22, 2019
Contributor
kylebuch8
left a comment
kylebuch8
left a comment
There was a problem hiding this comment.
Leo Gemini Taurus Maquarius
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This description got too long, extracted it into a blog post:
https://clayto.com/2019/07/web-component-icons/index.html