Skip to content

adding ability to disable a pfe-collapse-toggle button #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebuch8 merged 2 commits into from
Aug 28, 2019
Merged

adding ability to disable a pfe-collapse-toggle button #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af509ee
adding ability to disable a pfe-collapse-toggle button
kylebuch8 Aug 27, 2019
a23ac08
Merge branch 'master' into issue-516
mwcz Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions elements/pfe-collapse/demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,16 @@ <h2>Standalone Toggle without a Panel</h2>
Toggle without a panel
</pfe-collapse-toggle>

<hr>

<h2>Disabled Toggle</h2>
<pfe-collapse>
<pfe-collapse-toggle disabled="disabled">Disabled Toggle</pfe-collapse-toggle>
<pfe-collapse-panel>
<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
</pfe-collapse-panel>
</pfe-collapse>

<script>
var collapse = document.querySelector("pfe-collapse");
var panel = collapse.querySelector("pfe-collapse-panel");
Expand Down
4 changes: 4 additions & 0 deletions elements/pfe-collapse/src/pfe-collapse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ class PfeCollapseToggle extends PFElement {
}

toggle() {
if (this.hasAttribute("disabled")) {
return;
}

this.expanded = !this.expanded;

if (this.controlledPanel) {
Expand Down
22 changes: 22 additions & 0 deletions elements/pfe-collapse/test/pfe-collapse_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@
</pfe-collapse>
</div>

<div id="disabled">
<pfe-collapse>
<pfe-collapse-toggle disabled="disabled">Toggle</pfe-collapse-toggle>
<pfe-collapse-panel>Panel</pfe-collapse-panel>
</pfe-collapse>
</div>

<script>
suite("<pfe-collapse>", () => {
test("it should upgrade", () => {
Expand Down Expand Up @@ -241,6 +248,21 @@
`pfe-collapse-toggle: This toggle doesn't have a panel associated with it`
);
});

test("it should not open the panel if the toggle has been disabled", done => {
const collapse = document.querySelector('#disabled pfe-collapse');
const toggle = collapse.querySelector('pfe-collapse-toggle');
const panel = collapse.querySelector("pfe-collapse-panel");

toggle.click();

flush(() => {
assert.equal(toggle.getAttribute("aria-expanded"), "false");
assert.isTrue(!panel.hasAttribute("pfe-expanded"));

done();
});
});
});
</script>
</body>
Expand Down