Skip to content

adding one last check for a controlledPanel #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kylebuch8 merged 1 commit into from
Aug 28, 2019
Merged

adding one last check for a controlledPanel #523

kylebuch8 merged 1 commit into from
Aug 28, 2019

Conversation

@kylebuch8
Copy link
Contributor

@kylebuch8 kylebuch8 commented Aug 28, 2019

Fixes #522

adding one last check for a controlledPanel

What has changed and why

Summarize files edited as part of this MR along with a brief description of what was changed/why.

  • In certain scenarios, it's possible that the panel will be added to the DOM after the toggle has already been added. If a user were to click the toggle, it will never find the associated panel.
  • This fix gives the toggle one last opportunity to find the panel

Djfaucette
Djfaucette approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@Djfaucette Djfaucette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Languages: German, Turkish, Mongolian.

@kylebuch8 kylebuch8 merged commit 0c810a3 into master Aug 28, 2019
@kylebuch8 kylebuch8 deleted the issue-522 branch August 28, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Djfaucette Djfaucette Djfaucette approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pfe-collapse: what if the panel isn't in the DOM when the toggle is added to the DOM?

3 participants

@kylebuch8 @Djfaucette