adding a schema to pfe-icon-panel #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
castastrophe
suggested changes
Oct 18, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
Can you add a changelog? I added a couple notes and some questions for @starryeyez024 too.
castastrophe
added
the
needs changelog
added 2 commits
October 24, 2019 13:15
…to pfe-icon-panel-schema
castastrophe
previously approved these changes
Oct 24, 2019
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
A couple questions for @starryeyez024 about default values but otherwise this looks great 👍
starryeyez024
approved these changes
Oct 25, 2019
Member
starryeyez024
left a comment
starryeyez024
left a comment
There was a problem hiding this comment.
Liberty Guestbook Thoroughly Mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCHEMA!!!