Skip to content

Conversation

@Djfaucette
Copy link
Contributor

Title of this pull request

  • Link to discovery documentation (should contain all the planning and requirements for this work):
    • See the DISCOVERY.md template at the root of the project
  • Link(s) to demo pages where this element can be viewed:

What has changed and why

Summarize files edited as part of this MR along with a brief description of what was changed/why.

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 60.7.2 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Galaxy S9 Firefox
  • iPhone X Safari
  • iPad Pro Safari
  • Pixel 3 Chrome

Your repository infrastructure updates should work for at least:

  • Node v8.x
  • NPM v7.x

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Did browser testing pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@Djfaucette
Copy link
Contributor Author

@castastrophe Should I be doing math on the pfe-vars to get different sizes?

Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leather Gloves Tease Mittens

@kylebuch8 kylebuch8 merged commit ab5bc0e into master Oct 18, 2019
@kylebuch8 kylebuch8 deleted the add-progress-sizes branch October 18, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants