Skip to content

Conversation

@eyevana
Copy link
Contributor

@eyevana eyevana commented Oct 17, 2019

Maintain circled pfe-icon height in flex display

What has changed and why

Summarize files edited as part of this MR along with a brief description of what was changed/why.

  • Aligned the pfe-icon-panel's flex-children (ex. pfe-icon) to prevent their height from stretching to parent's height.

Testing instructions

Be sure to include detailed instructions on how your update can be tested by another developer.

  1. Pull the branch down and type run npm start in your local environment
  2. Navigate to http://localhost:8000/elements/pfe-icon-panel/demo/ and verify that the circled pfe-icon circles are not oblong :)

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 60.7.2 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Galaxy S9 Firefox
  • iPhone X Safari
  • iPad Pro Safari
  • Pixel 3 Chrome

Your repository infrastructure updates should work for at least:

  • Node v8.x
  • NPM v7.x

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Did browser testing pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?
  • Did you update the CHANGELOG.md file with a summary of this update?

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@eyevana eyevana requested review from kylebuch8 and markcaron and removed request for markcaron October 17, 2019 22:21
@eyevana eyevana mentioned this pull request Oct 17, 2019
7 tasks
@castastrophe castastrophe added 1.0 ready: code review Ready for code review! labels Oct 18, 2019
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally Grown Tomatoes, mmm...

@kylebuch8 kylebuch8 merged commit 93c5e99 into master Oct 22, 2019
@kylebuch8 kylebuch8 deleted the fix-icon-panel branch October 22, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready: code review Ready for code review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants