build: ignore compiled assets when determining version bumps #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
reviewed
Nov 8, 2019
| "elements/*/dist/*.css", | ||
| "elements/*/dist/*.js", | ||
| "elements/*/dist/*.map" | ||
| "elements/*/dist/**/*" |
Contributor
There was a problem hiding this comment.
Would it make sense to ignore the entire dist directory instead of just the files nested inside it? Also, there aren't any folders in the dist directory, just files so if you did want to keep the dist but ignore the files in it, dist/* would be sufficient.
Contributor
There was a problem hiding this comment.
I think we're being extra careful here on purpose.
Contributor
|
Needs a changelog :) -- unless we're ready to start automating that part! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore compiled assets when determining version bumps
Update lerna's
ignoreChangespatterns so that committing compiled assets doesn't trigger version bumps in every element, during every release. After this change, we should go back to the happy path of only the elements that change getting version bumps.