feat: Add event emission to pfe-cta (#741) #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 24, 2020 15:59
castastrophe
changed the title
Member
|
Tested, but not code reviewed (by me): Lender Growth Takes Money
|
added 6 commits
February 27, 2020 13:01
…k element and not just the text node; update tests
Closed
castastrophe
added
feature
Member
|
Just noting that I still have not heard back from SDI. However we could go ahead and merge (@kylebuch8 noted he was reviewing it and it looked good) and we can modify the events if need be later. One question @castastrophe , I don't see the cool alert thing anymore, is that still supposed to be on the demo page?
|
Contributor
Author
|
@starryeyez024 I bet it's in a commit that I haven't pushed up yet. I know I was waiting to get the thumbs up first and I think I was away from my computer when it came |
…ments into feat-issue-741-add-event-cta
Contributor
Author
|
@starryeyez024 I pushed everything up! I'll take a look once the netlify finishes building - maybe this afternoon. I have some free time between 2pm-4pm. |
alazzara
previously approved these changes
Mar 26, 2020
castastrophe
removed
ready: branch testing
alazzara
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741
What has changed and why
Summarize files edited as part of this MR along with a brief description of what was changed/why.
Testing instructions
Be sure to include detailed instructions on how your update can be tested by another developer.
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!