docs(a11y): create template for a11y docs #3019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-org-pr-3019-v4.surge.sh/v4 |
thatblindgeye
force-pushed
the
a11y_docs_templating
branch
from
0ff2657 to
e977bca
Compare
nicolethoen
previously approved these changes
Jun 28, 2022
Collaborator
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
I really like the structure!
This looks great to me! 😸
Collaborator
|
Looks awesome, love the check boxes. Great work! |
jessiehuff
previously approved these changes
Jun 28, 2022
Contributor
jessiehuff
left a comment
jessiehuff
left a comment
There was a problem hiding this comment.
This looks awesome!! 😄
thatblindgeye
dismissed stale reviews from jessiehuff, wolfeallison, and nicolethoen
via
f75c3b1
thatblindgeye
force-pushed
the
a11y_docs_templating
branch
2 times, most recently
from
f75c3b1 to
22ce6ea
Compare
Contributor
Author
|
Latest push adds a quick example for the |
nicolethoen
previously approved these changes
Jul 5, 2022
jessiehuff
previously approved these changes
Jul 5, 2022
thatblindgeye
dismissed stale reviews from jessiehuff and nicolethoen
via
98ac905
thatblindgeye
force-pushed
the
a11y_docs_templating
branch
from
22ce6ea to
98ac905
Compare
added 7 commits
July 6, 2022 14:42
thatblindgeye
force-pushed
the
a11y_docs_templating
branch
from
98ac905 to
88cd355
Compare
added 2 commits
July 6, 2022 14:54
mcarrano
added a commit
to mcarrano/patternfly-org
that referenced
this pull request
Jul 19, 2022
…nto text-input-group * 'main' of https://github.com/patternfly/patternfly-org: (170 commits) chore(release): releasing packages [ci skip] Updates button info architecture to align with guidelines. (patternfly#3061) Card design guideline changes. (patternfly#3087) chore(release): releasing packages [ci skip] iss3078 (patternfly#3079) chore(release): releasing packages [ci skip] changing alert guidelines (patternfly#3064) chore(release): releasing packages [ci skip] mastshead (patternfly#3062) chore(release): releasing packages [ci skip] jumplink (patternfly#3051) chore(release): releasing packages [ci skip] calendar (patternfly#3058) chore(release): releasing packages [ci skip] feat(doc-framework): add dark theme toggle for full page examples (patternfly#3056) chore(release): releasing packages [ci skip] edit overflow guidelines (patternfly#3038) chore(release): releasing packages [ci skip] docs(a11y): create template for a11y docs (patternfly#3019) docs(Tooltip): add a11y docs (patternfly#2892) ... # Conflicts: # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/attribute-value-filter.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/auto-complete-search.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/text-input-elements.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/text-input-group.md
jessiehuff
pushed a commit
to jessiehuff/patternfly-org
that referenced
this pull request
Oct 24, 2022
* docs(a11y): create template for a11y docs * Refactor template as webpage on PF site * Convert accordion doc to align with template * Update guidelines and accordion doc * Remove duplicate a11y info from accordion design guidelines * Make suggested updates * Update minor difference between guidelines * Add example for aria label prop * Separate out library instructions * Remove files after rebase * Update verbiage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2960
Accordion accessibility tab
This PR:
Adds a page under the Accessibility tab on the PF site, laying out how to write a11y documentation for componentsThis information is now in a new writing accessibility documentation for PatternFly wiki pageThis is more of a robust draft of what things could look like for a more consistent a11y documentation. We can cut out various areas or rework areas as needed.
A couple of other potential ideas that we could add down the line/depending on the component: