chore: simplify Babel configuration #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wise-king-sullyman merged 1 commit into patternfly:main from jonkoops:simplify-babel-config

Mar 25, 2024

Contributor

jonkoops commented Mar 24, 2024

Simplifies the Babel configuration by removing transformations that are no longer needed, and replacing them with relevant presets.

This change is needed to land patternfly/patternfly-react#10189


          chore: simplify Babel configuration

52a5da8

jonkoops commented

View reviewed changes

packages/documentation-framework/package.json

Contributor Author

jonkoops Mar 24, 2024

I've removed all the individual Babel transformations, since @babel/preset-env will already handle these automatically. I've also replaced @babel/plugin-transform-react-jsx with @babel/preset-react, which can do more in-depth optimization.

Collaborator

patternfly-build commented Mar 24, 2024

Preview: https://patternfly-org-pr-3934-site.surge.sh

jonkoops commented

View reviewed changes

packages/documentation-framework/scripts/webpack/webpack.base.config.js

Comment on lines -60 to -61

    
                              corejs: 3,

                              useBuiltIns: 'entry',

Contributor Author

jonkoops Mar 24, 2024

I've removed the core-js auto-polyfilling and related settings here. The reason for that is with useBuiltIns set to entry it is required to add an explicit import to core-js in the application code (see documentation).

Since the aforementioned import never existed in the application code this essentially means that core-js polyfills were also never included. So I have opted to plain out disable it to make this more explicit.

jonkoops commented

View reviewed changes

packages/documentation-framework/scripts/webpack/webpack.base.config.js

    
                              loose: true,

                              corejs: 3,

                              useBuiltIns: 'entry',

                              exclude: ['transform-regenerator', 'transform-async-to-generator'],

Contributor Author

jonkoops Mar 24, 2024

I've removed these transforms, as they are now implicitly no longer included by updating the targets field, as well as updating the browserlist database (change included in updated lockfile).

jonkoops commented

View reviewed changes

packages/documentation-framework/scripts/webpack/webpack.base.config.js

    
                              corejs: 3,

                              useBuiltIns: 'entry',

                              exclude: ['transform-regenerator', 'transform-async-to-generator'],

                              modules: false,

Contributor Author

jonkoops Mar 24, 2024

I've removed the modules field here, as this should be left to auto (the default) when using it in combination with a bundler such as WebPack + babel-loader, which is the case here (see documentation).

jonkoops commented

View reviewed changes

packages/documentation-framework/scripts/webpack/webpack.base.config.js

    
                              '@babel/preset-react',

                              ['@babel/preset-env', {

                                loose: true,

                                targets: '> 1%, not dead'

Contributor Author

jonkoops Mar 24, 2024

I've narrowed the support target, as this was matching a lot of unsupported browsers. The new target still has wide support for various browsers, but prevents excessive transpilation.

jonkoops commented

View reviewed changes

packages/documentation-framework/scripts/webpack/webpack.base.config.js

    
                                loose: true,

                                targets: '> 1%, not dead'

                              }],

                            ],

Contributor Author

jonkoops Mar 24, 2024

All these plugins are already supported by @babel/preset-env, so there is no need to specify them individually.

nicolethoen requested review from nicolethoen and wise-king-sullyman

March 25, 2024 12:59

nicolethoen approved these changes

View reviewed changes

jonkoops mentioned this pull request

chore: simplify Babel configuration patternfly/patternfly-react#10189

Merged

wise-king-sullyman approved these changes

View reviewed changes

Collaborator

wise-king-sullyman left a comment

🚀

wise-king-sullyman merged commit 95ba14c into patternfly:main

jonkoops deleted the simplify-babel-config branch

March 25, 2024 20:51

nicolethoen added a commit that referenced this pull request


          Rebase v6 (#3964)

189dd62

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.15
 - @patternfly/documentation-framework@5.3.15

* docs(extensions): Updates the extensions landing page to add reference to the component groups extension. (#3849)

* (docs(extensions): Updates the extensions landing page to add reference to the component groups extension.

* Update packages/documentation-site/patternfly-docs/pages/landing-pages/extensions/extensions-data.json

* typo update

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.16
 - @patternfly/documentation-framework@5.3.16

* docs(accessibility-design): Adds new documentation to support content audit. (#3781)

* docs(accessibility-design): Adds new documentation to support content audit.

* Test page name change

* Apply suggestions from code review

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-design.md

* Remove table

* Removes numbers from headings.

* Makes content updates and adds images.

* Updates to content describing images.

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.17
 - @patternfly/documentation-framework@5.3.17

* fix: bump puppeteer to fix core (#3860)

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.18
 - @patternfly/documentation-framework@5.3.18

* Update naming for introductory pages across website sections. (#3851)

* Update naming for introductory pages across website sections.

* Caps change

* Adjusts naming for about PatternFly page.

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.19
 - @patternfly/documentation-framework@5.3.19

* docs(accessibility-testing): Updates content as part of content audit. (#3776)

* docs(accessibility-testing): Updates content as part of content audit.

* Apply suggestions from code review

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

* Apply suggestions from code review

* Content tweaks in progress.

* Works on checkboxes.

* Resolves merge conflict.

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

* Content alterations.

* Content changes from review feedback.

* Updates to buttons point.

* Grammar and typo updates.

* Update packages/documentation-site/patternfly-docs/content/developer-resources/accessibility-testing.md

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

* Merging.

---------

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.20
 - @patternfly/documentation-framework@5.3.20

* fix: bump to latest release candidates ahead of 5.2 release (#3862)

* fix: bump to latest release candidates ahead of 5.2 release

* bump to latest component groups prerelease

* bump react to pull in bug fix

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.21
 - @patternfly/documentation-framework@5.3.21

* updates to images to make icons black (#3856)

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.22
 - @patternfly/documentation-framework@5.3.22

* fix: avoid applying beta tags to nav items for next components (#3868)

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.23
 - @patternfly/documentation-framework@5.3.23

* fix(truncate): typos on guidelines (#3872)

* docs(capitalization): Updates capitalization guidelines for better consistency and clarity. (#3855)

* docs(capitalization): Updates guidance for capitalization.

* Continues editing content.

* Content updates progress.

* Updates content and images.

* Content and image updates.

* Final content and image updates.

* Updates recs per content team decision.

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.24
 - @patternfly/documentation-framework@5.3.24

* fix: add drag drop deps and remove unused code editor deps (#3866)

* fix: add drag drop deps and remove unused code editor deps

* bump react-docs to fix error

* bump the prerelease versions

* chore(Title): updated a11y docs to template (#3873)

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.25
 - @patternfly/documentation-framework@5.3.25

* docs(release-highlights): Adds release highlights for 5.2 release. (#3853)

* docs(releases): Adds release highlights for v5.2

* docs(release-highlights): Adds release highlights for 5.2 release.

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

* Adds more highlights.

* Adds coming soon section.

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

---------

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.26
 - @patternfly/documentation-framework@5.3.26

* docs(design): Adds initial information regarding Figma. (#3863)

* docs(design): Adds Figma information where Sketch is currently mentioned.

* Path update

* Update packages/documentation-site/patternfly-docs/content/contribute/design/design.md

* Path updates.

* Update packages/documentation-site/patternfly-docs/content/contribute/design/design.md

* Update packages/documentation-site/patternfly-docs/content/training/design.md

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.3.27
 - @patternfly/documentation-framework@5.3.27

* feat: release 5.3 (#3878)

* feat: 5.3 release

* update release highlights

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.4.0
 - @patternfly/documentation-framework@5.4.0

* fix: Bump topology to 5.2.1 (#3881)

* fix: toplogy to 5.2.1

* add yarn.lock

* update release highlights

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.4.1
 - @patternfly/documentation-framework@5.4.1

* Update broken link on develop.md

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.4.2
 - @patternfly/documentation-framework@5.4.2

* chore(deps): bump ip from 1.1.5 to 1.1.9 (#3895)

Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.5...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add edit modal guidance (#3836)

* add edit modal guidance

* edits

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.4.3
 - @patternfly/documentation-framework@5.4.3

* chore(release): Updated component groups to 5.1.0 release (#3917)

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.4.3
 - @patternfly/documentation-framework@5.4.3

chore(component-groups): Updated component groups to 5.1.0 release

chore(component-groups): Updated component groups to 5.1.0 release

* Updated version.json

* feat(deps): version bump for 5.2.1 release (#3913)

* feat(deps): version bump for 5.2.1 release

* Update packages/documentation-framework/versions.json

Co-authored-by: Evan <evan.wilkinson@gmail.com>

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

Co-authored-by: Evan <evan.wilkinson@gmail.com>

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

Co-authored-by: Evan <evan.wilkinson@gmail.com>

* Update packages/documentation-framework/versions.json

* chore(deps): bump react-charts, react-docs

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>

* chore(docs): update release highlights

* Update packages/documentation-framework/versions.json

---------

Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.5.0
 - @patternfly/documentation-framework@5.5.0

* chore(SkipToContent): updated a11y docs to template (#3871)

* chore(SkipToContent): updated a11y docs to template

* Updated test item description verbiage

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.5.1
 - @patternfly/documentation-framework@5.5.1

* feat(deps): version bump and release notes for 5.2.2 patch release (#3919)

* feat(deps): version bump and release notes for 5.2.2 patch release

* fix(release-highlights): correct listed table version

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>

---------

Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.6.0
 - @patternfly/documentation-framework@5.6.0

* feat: add pf 6 alpha banner to home page and version switcher (#3896)

* feat: add pf 6 alpha banner to home page and version switcher

* update wording

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.7.0
 - @patternfly/documentation-framework@5.7.0

* feat(templates): add templates package to versions.json (#3902)

* feat(templates): add templates package to versions.json for docs build

* add support for template inline alert

* add to patch version, update wording

* update wording

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.8.0
 - @patternfly/documentation-framework@5.8.0

* chore(Page): updated a11y docs to new template (#3880)

* chore(Page): updated a11y docs to new template

* Removed requirement of aria-labelledby on page sections

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.8.1
 - @patternfly/documentation-framework@5.8.1

* chore: simplify Babel configuration (#3934)

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.8.2
 - @patternfly/documentation-framework@5.8.2

* chore(footer): Restructure new homepage footer (#3870)

* Restructure footer

* Remove PageSection from footer based on conversations

* Rework structure

* Fix footer height issue

* Update flex

* Fix typo

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.8.3
 - @patternfly/documentation-framework@5.8.3

* feat(docs): update medium articles (#3950)

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.9.0
 - @patternfly/documentation-framework@5.9.0

* docs(release-highlights): Creates release highlights for 5.3 release. (#3941)

* docs(release-highlights): Creates release highlights for 5.3 release.

* Continues working on content updates.

* docs(release-highlights): Adds release highlights for 5.3 release.

* Adds more context to menu toggle change.

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

* Update packages/documentation-site/patternfly-docs/content/get-started/release-highlights.md

* Adds section for dual list selector.

* Updates topology pipeline images.

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.9.1
 - @patternfly/documentation-framework@5.9.1

* feat(Templates): add to org site (#3947)

* feat(Templates): add to org site

* update versions, fix Th

* hide prev version, update screenshots

* chore(release): releasing packages [ci skip]

 - @patternfly/ast-helpers@1.10.0
 - @patternfly/documentation-framework@5.10.0

* update documentation-framework version and git ignore

* remove react-templates untill merged in react

* remove 1 featured post

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Nicole Thoen <nthoen@redhat.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Margot <51165119+mmenestr@users.noreply.github.com>
Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Donald Labaj <dlabaj@redhat.com>
Co-authored-by: Austin Sullivan <ausulliv@redhat.com>
Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Jon Koops <jonkoops@gmail.com>
Co-authored-by: Jessie <jhuff@redhat.com>
Co-authored-by: Titani <tlabaj@redaht.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet