Skip to content

fix(sideNav): Temporarily harcode breakpoint tokem token value #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlabaj merged 1 commit into from
Sep 18, 2024
Merged

fix(sideNav): Temporarily harcode breakpoint tokem token value #4262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/documentation-framework/components/sideNav/sideNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { Label, Nav, NavList, NavExpandable, PageContextConsumer, capitalize, Fl
import { css } from '@patternfly/react-styles';
import { Location } from '@reach/router';
import { makeSlug } from '../../helpers';
import globalBreakpointXl from "@patternfly/react-tokens/dist/esm/global_breakpoint_xl";
// temp fix for tokens changes. uncomment next line once rect-core PR #11002 goes in and org bumps the versions
//import globalBreakpointXl from "@patternfly/react-tokens/dist/esm/global_breakpoint_xl";
import { trackEvent } from '../../helpers';

const getIsActive = (location, section, subsection = null) => {
Expand All @@ -15,7 +16,9 @@ const getIsActive = (location, section, subsection = null) => {
const defaultValue = 50;

const NavItem = ({ text, href, isDeprecated, isBeta, isDemo }) => {
const isMobileView = window.innerWidth < Number.parseInt(globalBreakpointXl.value, 10);
// temp fix for tokens changes. uncomment next line and delete line 21 once rect-core PR #11002 goes in and org bumps the versions
// const isMobileView = window.innerWidth < Number.parseInt(globalBreakpointXl.value, 10);
const isMobileView = window.innerWidth < Number.parseInt("75rem", 10);
return (
<PageContextConsumer key={href + text}>
{({onSidebarToggle, isSidebarOpen }) => (
Expand Down