fix(sideNav): revert temp fix for tokens update#4270
Merged
evwilkin merged 7 commits intopatternfly:mainfrom Sep 23, 2024
Merged
fix(sideNav): revert temp fix for tokens update#4270evwilkin merged 7 commits intopatternfly:mainfrom
evwilkin merged 7 commits intopatternfly:mainfrom
Conversation
Member
|
@tlabaj this was failing CI as the versions weren't bumped to pull in the fix from react-tokens. I pulled it locally and got it working after a few tries so pushed the version bumps back up to this PR to see if we can get CI passing. |
Member
|
@tlabaj this CI error is what we see what the |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4264