fix: use inline svg for brand logo#193
Merged
nicolethoen merged 1 commit intopatternfly:v6from Dec 20, 2023
Merged
Conversation
|
@nicolethoen out of curiousity.... why did you shift to inline ? I also dont see anything referencing the original path ( |
Collaborator
Author
|
@gregswift It's not the only way it can be done, but it required the least configuration updates. If all your images in your app are inline svgs, then you wouldn't need the src/app/bgimages. That is still where the app expects to load/import assets from if they are included in a more tradiitonal way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.