You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tlabaj I need to update snapshots with the new alpha version bump for Nav no longer having the theme prop as well as the pf-m-expandable class being removed as seen in your PR.
In checking before updating the snapshot, the theme prop is straightforward but I'm having trouble confirming that the pf-m-expandable is something that should be removed, as it looks to still be on the Core markup. Do you mind taking a look to confirm that this class should be dropped?
@tlabaj I need to update snapshots with the new alpha version bump for Nav no longer having the theme prop as well as the pf-m-expandable class being removed as seen in your PR.
In checking before updating the snapshot, the theme prop is straightforward but I'm having trouble confirming that the pf-m-expandable is something that should be removed, as it looks to still be on the Core markup. Do you mind taking a look to confirm that this class should be dropped?
I believe core examples need to be updated. The pf-m-expandable modifier no longer exists in the style sheet so I talked to @mattnolting and removed it in React.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps versions:
Fixes type errors thrown in
Nav&&EmptyStatecomponents due to changes in these components in newer versions.