Test error: Cannot find the Button's aria-disabled attribute

[dlabrecq]

Please describe the issue

2 tests cannot find the Button's aria-disabled attribute. This test worked with v5, but no longer works with v6.

Are there visuals for this issue? Please provide screenshots

Error 1

Error 2

Could you point to a branch or draft PR where this issue exists? Please provide a link to the code

Error 1

• Test https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/components/addPriceList.test.tsx#L186
• Button https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/components/addPriceList.tsx#L63

Error 2

• Test https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/components/addPriceList.test.tsx#L244
• Button https://github.com/dlabrecq/koku-ui/blob/pf-v6/src/routes/settings/costModels/components/addPriceList.tsx#L63

[wise-king-sullyman]

These failures are in part because of the same cause as #10927, and in part because we have updated the isDisabled prop for Button to set only disabled for button elements and not aria-disabled.

Along with my suggestion in that other issue I would suggest using the toBeDisabled matcher from jest-dom rather than checking for aria-disabled explicitly for these tests.

[dlabrecq]

It's unclear why the previous developer chose to test aria-disabled, but changed to use toBeDisabled