Wrong (outdated) type definition for DropDownGroup and SelectGroup?

[ancorgs]

Describe the problem
This is an issue with Patternfly 6 (at least)

The label property of MenuGroup is declared as type ReactNode. It can indeed handle that and we use it at Agama.

But in the case of DropDownGroup and SelectGroup the properties label are defined as type string. They can actually handle everything that MenuGroup's label can handle (eg. see agama-project/agama#1977).

Internally SelectGroup is using MenuGroup. So the limitation doesn't make fully sense to me, although it could be intentional for some reason I'm overlooking.

MenuGroup#label was an string until two years ago, #8219 and the component itself was added 5 years ago e867f09 While the SelectGroup#label types dates from 6 years ago. All that makes me think that those types were simply left behind by omission.

How do you reproduce the problem?

See agama-project/agama#1977

Expected behavior

Type check does not fail when a ReactNode is used as label for DropDownGroup or SelectGroup.

Is this issue blocking you?

The workarounds are to disable type checking for that file or to use a Menu instead of a DropDown. Both doable but annoying.

[Mash707]

@thatblindgeye Are we proposing a change like label? : React.ReactNode for SelectGroup and DropdownGroup? If yes, you can assign this to me, will put up a PR.

patternfly-react/packages/react-core/src/components/Select/SelectGroup.tsx

Line 13 in dace189

label?: string;

patternfly-react/packages/react-core/src/components/Dropdown/DropdownGroup.tsx

Line 13 in dace189

label?: string;

patternfly-react/packages/react-core/src/components/Menu/MenuGroup.tsx

Line 11 in dace189

label?: React.ReactNode;

[thatblindgeye]

@Mash707 yes that's correct. We're not doing any string specific things on the label prop so we should be safe to update SelectGroup and DropdownGroup to match MenuGroup's type.