TabContent renders incorrect Content

[abhinandan13jan]

Describe the issue. What is the expected and unexpected behavior?
TabContents is rendered using index as Key, instead of the Tab's {eventKey} prop. This causes Content mismatch for a Tab.

Example.

We have 3 tabs ->  
Tab 1 -> Title : "Terminal 21", TabContent: "oc get pods"
Tab 2 -> Tiltle: "Terminal 24", TabContent: "This content should have been removed"
Tab 3 -> Title: "Terminal 26", TabContent: "correct content"

Now, If we remove "Tab 2", we get 
Tab 1 -> Title : "Terminal 21", TabContent: "oc get pods"
Tab 2 -> Title: "Terminal 26", TabContent: "This content should have been removed" 

instead of 

Tab 1 -> Title : "Terminal 21", TabContent: "oc get pods"
Tab 2 -> Title: "Terminal 26", TabContent: "correct content"

This occurs as 
 <TabContent
              key={index}

 instead of something like             
  <TabContent
              key={child.props.eventKey}          

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.

1. Create a Tab using custom eventKey which are not in order/sync with the index.
2. Dynamically remove a tab from middle of the array of Tab
3. The TabContent is not removed and is simply passed to the next Tab's TabContent

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
Blocking. Bug

What is your product and what release version are you targeting?
Openshift Console 4.11

[christianvogt]

Looks like the key prop given to a Tab is lost in the Tabs component which then uses index as a key:

patternfly-react/packages/react-core/src/components/Tabs/Tabs.tsx

Line 425 in f31fca2

key={index}

        {filteredChildren
          .filter(
            child =>
              child.props.children &&
              !(unmountOnExit && child.props.eventKey !== localActiveKey) &&
              !(mountOnEnter && shownKeys.indexOf(child.props.eventKey) === -1)
          )
          .map((child, index) => (
            <TabContent
              key={index}
              activeKey={localActiveKey}
              child={child}
              id={child.props.id || uniqueId}
              ouiaId={child.props.ouiaId}
            />
          ))}

[abhinandan13jan]

when is the fix expected to be released?

[mcarrano]

We will add this to our 2022.06 milestone targeted for a mid-May release.