Skip to content

Tabs - add border-bottom variation for secondary tabs, update demo #7259

@mcoker

Description

@mcoker

Issue: patternfly/patternfly#4753
PR: patternfly/patternfly#4774

  • Adds .pf-m-border-bottom to add a bottom border to secondary tabs.
  • Updates secondary tabs in "Open tabs with secondary tabs" demo
  • Also see if we can match the structure in the core demo. We need to remove the extra space between the primary and secondary tabs, and make sure the secondary tabs extends to the edge of the container with an inset, so the border goes to the edge of the container.
    • If we can't match the core structure, you should be able to do that with the current example by:
      • Add .pf-m-no-padding to page section that wraps secondary tabs and tab content
      • Add .pf-m-page-insets to secondary tabs (and remove .pf-m-inset-none)
      • Add .pf-m-padding to the .pf-c-tab-content__body element that wraps the "Pod details" content
      • Side note - the first tab content element in this demo is in it's own div, and the others are in another, and those divs are wrapped in a flex layout - could the flex layout just be removed and the tab content elements all be adjacent to one another? Only one should show at a time.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions