Skip to content

DashboardWrapper demo updates #8130

@mcoker

Description

@mcoker

re: #7927 (review)

I think we want the vertical nav's aria-label to be "Global", otherwise the rotor reads this as "Nav navigation". "Global" is the default, so if we want to update, you could remove this entirely. This also matches the <PageToggleButton>'s aria-label, and those labels should probably match.

<Nav onSelect={this.onNavSelect} aria-label="Nav">

<PageToggleButton variant="plain" aria-label="Global navigation">


A bunch of the demos have body text that references the Overpass font and some specific font styles that aren't relevant and may change (and be incorrect) as styles change over time. Just in general, I'd say we should review the body text of demos/examples and make sure we don't have other stuff like this. Here's a list of the places I found that reference the overpass text

packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Nav.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/PrimaryDetail.md:              Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Banner.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/Banner.md:                    Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/examples/BackToTop/BackToTopNameDemo.tsx:              Body text should be Overpass Regular at 16px.It should have leading of 24px because <br />
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-core/src//demos/NotificationDrawer/NotificationDrawer.md:                Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />
packages/react-table/src//docs/examples/ComposableTableStickyToolbar.tsx:              Body text should be Overpass Regular at 16px. It should have leading of 24px because <br />

This page section should be isWidthLimited, or maybe some mechanism to add/remove that depending on what else is on the page (like if other page sections aren't width limited?), though I'm not sure if there is ever a use case where this wouldn't be width limited. I guess it doesn't matter here since the text isn't very long, but if more content is added, it will keep it from spanning the whole viewport.

<PageSection variant="light">
<TextContent>
<Text component="h1">Main title</Text>
<Text component="p">This is a full page demo.</Text>
</TextContent>
</PageSection>

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions