-
Notifications
You must be signed in to change notification settings - Fork 377
Closed
Description
Describe the problem
When passing in aria-label to the SimpleList component, the attribute gets applied to the outer div. This causes axe to flag it as aria labels aren't well supported on div elements.
The aria-label should instead be applied to the ul element that gets rendered instead (currently the isGrouped variation applies an aria-labelledby, so this fix would most likely only need to be applied at line ~77 of the SimpleList code:
patternfly-react/packages/react-core/src/components/SimpleList/SimpleList.tsx
Lines 75 to 78 in d68f302
| <div className={css(styles.simpleList, className)} {...props}> | |
| {isGrouped && children} | |
| {!isGrouped && <ul>{children}</ul>} | |
| </div> |
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done