Skip to content

Bug - react-styles - class names need to be updated #9150

@tlabaj

Description

@tlabaj

Describe the problem
A clear and concise description of the problem. Which components are affected?
The component class definitions in react-styles (https://github.com/patternfly/patternfly-react/tree/v5/packages/react-styles/src/css/components) need to be updated to use the v5 prefix.

in addition this comment from @mcoker should be addressed

re: the react-styles updates @tlabaj mentioned, I'm not sure where the names for the color vars are coming from - https://github.com/patternfly/patternfly-react/blob/v5/packages/react-styles/src/css/components/Table/inline-edit.css

We don't have a --global--[color]--number CSS var in core, though it looks like that is how the vars were defined before we added the v5 prefix, too - 3879fc7#diff-d99fb7d33fdb9c29c555e2926969439a2857b3ec7e95c13155c6c21bb3dce1e2

I can't find an editable table example using composable table, but I see the legacy table example - https://www.patternfly.org/v4/components/table/react-legacy#editable-rows. It doesn't look like any of the classnames in https://github.com/patternfly/patternfly-react/blob/v5/packages/react-styles/src/css/components/Table/inline-edit.css are being applied in edit mode.

If those colors still need to be applied, --pf-v5-global--[color]--[number] should be --pf-v5-global--palette--[color]-[number] - and the color names should be lower-case.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions