Bug - Popper - Component crash when no children defined

[nicolethoen]

The popper component is throwing an error (see screen grab and stack trace below)

Changing https://github.com/openshift/console/blob/0ed60b588f0be2090f3bec5a6a4c4e67eb8dc1ef[…]ents/dropdown/dropdown-with-switch/DropdownWithSwitchToggle.tsx to popper={<>{menu}</>} is a hack to workaround the issue.

In OCP's case, the Popper's popper prop is receiving a DropdownWithSwitchMenu component as a value which is of type React.FC<DropdownWithSwitchMenuProps>. This menu does not have a children prop, so the error is thrown, unless it's wrapped in a React fragment. Some sort of coercion of types is happening. Maybe the type of the popper prop needs to be tightened to prevent this run time error?

Screen.Recording.2023-12-18.at.3.02.32.PM.1.mov