Skip to content

feat(Dropdown): Added support for setting height for dropdown #10149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wise-king-sullyman merged 2 commits into from
Mar 26, 2024
Merged

feat(Dropdown): Added support for setting height for dropdown #10149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
306c35c
feat(Dropdown): Added support for setting height for dropdown
tlabaj Mar 8, 2024
dd271ab
apply isScrollable to menu if maxMenuHeight or menuHeight is defined
tlabaj Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/react-core/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ export interface DropdownProps extends MenuProps, OUIAProps {
zIndex?: number;
/** Additional properties to pass to the Popper */
popperProps?: DropdownPopperProps;
/** Height of the dropdown menu */
menuHeight?: string;
/** Maximum height of dropdown menu */
maxMenuHeight?: string;
}

const DropdownBase: React.FunctionComponent<DropdownProps> = ({
Expand All @@ -83,6 +87,8 @@ const DropdownBase: React.FunctionComponent<DropdownProps> = ({
zIndex = 9999,
popperProps,
onOpenChangeKeys = ['Escape', 'Tab'],
menuHeight,
maxMenuHeight,
...props
}: DropdownProps) => {
const localMenuRef = React.useRef<HTMLDivElement>();
Expand Down Expand Up @@ -138,6 +144,8 @@ const DropdownBase: React.FunctionComponent<DropdownProps> = ({
};
}, [isOpen, menuRef, toggleRef, onOpenChange, onOpenChangeKeys]);

const scrollable = maxMenuHeight !== undefined || menuHeight !== undefined || isScrollable;

const menu = (
<Menu
className={css(className)}
Expand All @@ -147,11 +155,13 @@ const DropdownBase: React.FunctionComponent<DropdownProps> = ({
shouldFocusToggleOnSelect && toggleRef.current.focus();
}}
isPlain={isPlain}
isScrollable={isScrollable}
isScrollable={scrollable}
{...props}
{...ouiaProps}
>
<MenuContent>{children}</MenuContent>
<MenuContent menuHeight={menuHeight} maxMenuHeight={maxMenuHeight}>
{children}
</MenuContent>
</Menu>
);
return (
Expand Down