feat(Nav): Added default nav item wrapper. Added support for nav item icons#10687
Merged
wise-king-sullyman merged 4 commits intopatternfly:v6from Jul 11, 2024
Merged
feat(Nav): Added default nav item wrapper. Added support for nav item icons#10687wise-king-sullyman merged 4 commits intopatternfly:v6from
wise-king-sullyman merged 4 commits intopatternfly:v6from
Conversation
tlabaj
requested review from
a team,
kmcfaul,
mattnolting,
thatblindgeye and
wise-king-sullyman
and removed request for
a team
This was
linked to
issues
Jul 1, 2024
Collaborator
|
Preview: https://patternfly-react-pr-10687.surge.sh A11y report: https://patternfly-react-pr-10687-a11y.surge.sh |
andrew-ronaldson
approved these changes
Jul 2, 2024
Collaborator
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
B-E-A-uuuuutiful!
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
One nit, but other than that looks great!
| > | ||
| {hasNavLinkWrapper ? <span className={css(`${styles.nav}__link-text`)}>{children}</span> : children} | ||
| {flyout && flyoutButton} | ||
| {icon && <span className={css(`${styles.nav}__link-icon`)}>{icon}</span>} |
Collaborator
There was a problem hiding this comment.
Suggested change
| {icon && <span className={css(`${styles.nav}__link-icon`)}>{icon}</span>} | |
| {icon && <span className={css(styles.navLinkIcon)}>{icon}</span>} |
thatblindgeye
requested changes
Jul 3, 2024
| {...props} | ||
| > | ||
| {hasNavLinkWrapper ? <span className={css(`${styles.nav}__link-text`)}>{children}</span> : children} | ||
| {flyout && flyoutButton} |
Contributor
There was a problem hiding this comment.
This will need to be added back in. Right now the Flyout example doesn't render the icon to indicate the item has any sort of interaction (item "Flyout link 3" in the following screenshot):
Contributor
Author
There was a problem hiding this comment.
oops that was a paste mistake! good catch!
thatblindgeye
approved these changes
Jul 3, 2024
nicolethoen
approved these changes
Jul 5, 2024
wise-king-sullyman
approved these changes
Jul 11, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9755 #10685
Additional issues: