Skip to content

Conversation

@jonkoops
Copy link
Contributor

Adds a linting task called lint:publication which integrates publint so that it is ran on every package in the workspace that is published to NPM. This allows common errors to be caught, especially in relation to publishing dependencies that have mixed CommonJS and ES modules.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 17, 2024

@jonkoops
Copy link
Contributor Author

jonkoops commented Jul 18, 2024

Note that I haven't added this script to run on CI, as it currently fails. There are several issues in the packages that will need to be resolved before this can be enabled.

@nicolethoen
Copy link
Contributor

Note that I haven't added this script to run on CI, as it currently fails. There are several issues in the packages that will need to be resolved before this can be enabled.

Is there a way we can document those issues? in a follow up issue maybe?

@jonkoops
Copy link
Contributor Author

jonkoops commented Aug 2, 2024

Is there a way we can document those issues? in a follow up issue maybe?

That would work, I can log some follow up tasks with a tracker if you like.

@jonkoops
Copy link
Contributor Author

jonkoops commented Aug 2, 2024

I'll mark this one as ready to review, and log some follow up issues.

@jonkoops jonkoops marked this pull request as ready for review August 2, 2024 16:46
Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops jonkoops changed the base branch from main to v6 August 22, 2024 09:28
@jonkoops
Copy link
Contributor Author

Since main is now in freeze I went ahead and re-directed this PR to the v6 branch.

@tlabaj tlabaj merged commit 2e6837e into patternfly:v6 Aug 22, 2024
@jonkoops jonkoops deleted the package-lint branch August 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants