Skip to content

feat(Masthead): Updates for new masthead structure in Penta#10809

Merged
srambach merged 7 commits intopatternfly:v6from
tlabaj:masthead
Jul 29, 2024
Merged

feat(Masthead): Updates for new masthead structure in Penta#10809
srambach merged 7 commits intopatternfly:v6from
tlabaj:masthead

Conversation

@tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jul 26, 2024 •
edited
Loading

What: Closes #10788

  • Renamed MastheadBrand to MastheadLogo
  • Renamed MastheadMain to MastheadBrand
  • Wrap MastheadToggle and MastheadBrand in MastheadMain

Codemod issue: patternfly/pf-codemods#718

@tlabaj tlabaj requested review from a team, andrew-ronaldson, kmcfaul, srambach and wise-king-sullyman and removed request for a team July 26, 2024 00:02
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 26, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10809.surge.sh

A11y report: https://patternfly-react-pr-10809-a11y.surge.sh

@tlabaj tlabaj mentioned this pull request Jul 26, 2024
Closed
@tlabaj tlabaj linked an issue Jul 26, 2024 that may be closed by this pull request
Masthead - updates to support better logo layout #10788
Closed
srambach
srambach reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surge is down so I haven't run it yet but had a couple of questions. Otherwise looks good on inspection!

@tlabaj tlabaj requested a review from edonehoo July 26, 2024 14:08
edonehoo
edonehoo suggested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since surge is down, this is going off the file changes as best I can. can re-review if/when surge comes back to make sure I checked everything, but this probably covers the main things regardless!

@tlabaj tlabaj requested review from edonehoo and srambach July 26, 2024 17:32
kmcfaul
kmcfaul approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We may want to open a follow up in org if we don't already have one to update the structure for the docs site (the surge masthead is the old structure still).

andrew-ronaldson
andrew-ronaldson approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

srambach
srambach approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ⭐

@srambach srambach merged commit 266ee47 into patternfly:v6 Jul 29, 2024
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jul 29, 2024

Your changes have been released in:

  • @patternfly/react-charts@8.0.0-alpha.35
  • @patternfly/react-code-editor@6.0.0-alpha.93
  • @patternfly/react-core@6.0.0-alpha.93
  • @patternfly/react-docs@7.0.0-alpha.101
  • @patternfly/react-drag-drop@6.0.0-alpha.75
  • @patternfly/react-icons@6.0.0-alpha.33
  • @patternfly/react-integration@6.0.0-alpha.47
  • demo-app-ts@5.1.1-alpha.92
  • @patternfly/react-styles@6.0.0-alpha.32
  • @patternfly/react-table@6.0.0-alpha.94
  • @patternfly/react-templates@6.0.0-alpha.43
  • @patternfly/react-tokens@6.0.0-alpha.32

Thanks for your contribution! 🎉

@tlabaj tlabaj mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@srambach srambach srambach approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

+1 more reviewer

@edonehoo edonehoo edonehoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Masthead - updates to support better logo layout

8 participants

@tlabaj @patternfly-build @wise-king-sullyman @srambach @andrew-ronaldson @kmcfaul @thatblindgeye @edonehoo