fix(Menu): update drilldown transition event handler #10839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-10839.surge.sh A11y report: https://patternfly-react-pr-10839-a11y.surge.sh |
tlabaj
approved these changes
Aug 8, 2024
thatblindgeye
approved these changes
Aug 12, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10840
Updates the logic for Menu to only include the drilldown transition handler when the Menu is a drilldown (after transitions were added in core to the base Menu, this event handler was firing for all Menus instead of only Drilldowns).
Updates the logic in Dropdown/Select/MenuContainer to focus the first item on an isOpen change rather than in the click handler.
Adds
shouldFocusFirstItemOnOpento MenuContainer for parity.