fix(DualListSelector example): improved behaviour when filter is applied#11097
Merged
tlabaj merged 4 commits intopatternfly:mainfrom Oct 29, 2024
Merged
fix(DualListSelector example): improved behaviour when filter is applied#11097tlabaj merged 4 commits intopatternfly:mainfrom
tlabaj merged 4 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11097.surge.sh A11y report: https://patternfly-react-pr-11097-a11y.surge.sh |
…lter - "move all" button moves only those options that are visible due to the filter - change "number of options selected" text based on number of options shown due to the filter - when having selected options, then filtering them out, the "move selected" button will be disabled and won't move them
adamviktora
force-pushed
the
dls-tree-example
branch
from
77e6e02 to
a596815
Compare
adamviktora
force-pushed
the
dls-tree-example
branch
from
2a74b8c to
7c7a81d
Compare
adamviktora
requested review from
a team,
tlabaj and
wise-king-sullyman
and removed request for
a team
kmcfaul
approved these changes
Oct 22, 2024
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
lgtm. I don't think it necessarily needs to be backported to v5 since v6 is on the horizon, and it's an example update.
tlabaj
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10862