fix(nav): Allow nav to expand by prop change #1345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
nav-expandable
branch
from
2513c06 to
ca68e53
Compare
Collaborator
|
PatternFly-React preview: https://1345-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4370
💛 - Coveralls |
Member
|
@ibolton336, this fix appears to have introduced a bug where previously expanded sections that have been collapsed are re-expanded on next navigate.
cc: @spadgett, @janwright73 |
priley86
reviewed
Feb 28, 2019
| value: this.props.defaultValue | ||
| }; | ||
|
|
||
| componentWillReceiveProps(nextProps) { |
Member
There was a problem hiding this comment.
this lifecycle method is soon to be deprecated. It works with our target version of React, but I recommend looking at getDerivedStateFromProps and componentDidUpdate.
https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops
https://egghead.io/lessons/react-refactor-componentwillreceiveprops-to-getderivedstatefromprops-in-react-16-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: fixes #1016
Additional issues: