Skip to content

fix(inputgroup): fix typescript and examples #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlabaj merged 1 commit into from
Mar 4, 2019
Merged

fix(inputgroup): fix typescript and examples #1489

tlabaj merged 1 commit into from
Mar 4, 2019

Conversation

@boaz0
Copy link
Member

@boaz0 boaz0 commented Mar 4, 2019

fixes #1488
closes #1483

@boaz0
fix(inputgroup): fix typescript and examples
9cdbb29 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 mentioned this pull request Mar 4, 2019
Merged
@tlabaj tlabaj added PF4 labels Mar 4, 2019
tlabaj
tlabaj requested changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boaz0 Can you add this component to the react-integration App?

@boaz0
Copy link
Member Author

boaz0 commented Mar 4, 2019

@tlabaj yes sure. 😄

@priley86
Copy link
Member

priley86 commented Mar 4, 2019

thanks @boaz0 - i also hope to see these ts errors show up in the IDE soon too. Failing the build would be terrific too 👍

tlabaj
tlabaj approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 59c29a5 into patternfly:master Mar 4, 2019
@tlabaj tlabaj mentioned this pull request Mar 4, 2019
Closed
@tlabaj
Copy link
Contributor

tlabaj commented Mar 4, 2019

@boaz I opened issue #1492 for adding the component to the rect integration App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlabaj tlabaj tlabaj approved these changes

+1 more reviewer

@priley86 priley86 priley86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4 v2.3.0: InputGroup contains TypeScript errors PF4: Update the Examples in the InputGroup to match core

3 participants

@boaz0 @priley86 @tlabaj