chore(inputgroup): add input group to react-integration #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
reviewed
Mar 5, 2019
packages/patternfly-4/react-core/src/components/InputGroup/InputGroupText.d.ts
Outdated
Show resolved
Hide resolved
dlabaj
requested changes
Mar 5, 2019
Contributor
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
Looks like you have a typescript linting error.
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 545 545
Lines 5658 5658
Branches 12 12
=======================================
Hits 4718 4718
Misses 938 938
Partials 2 2
Continue to review full report at Codecov.
|
Member
Author
|
Thanks @dlabaj - fixed that. |
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
dlabaj
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1492
What I changed
InputGroupandInputGroupTextto react-integrationcomponentprop's type toReactType