Fix(#1371): Fix for null and undefined rendering in table cell #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where an error is thrown and applications crash when there is null as value in one of
the table cells.
Fix # console.warn(`Cell value at [ ${rowKey}, ${key} ] should not be set to ${curr}`);
dlabaj
requested review from
dlabrecq,
ibolton336,
jschuler,
karelhala,
priley86 and
tlabaj
Collaborator
|
PatternFly-React preview: https://1621-pr-patternfly-react-patternfly.surge.sh |
karelhala
previously approved these changes
Mar 21, 2019
Contributor
karelhala
left a comment
karelhala
left a comment
There was a problem hiding this comment.
Looks good! UI wise it's good as well.
dlabrecq
previously approved these changes
Mar 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
- Coverage 82.89% 82.87% -0.02%
==========================================
Files 573 573
Lines 6249 6255 +6
Branches 75 75
==========================================
+ Hits 5180 5184 +4
- Misses 1039 1041 +2
Partials 30 30
Continue to review full report at Codecov.
|
tlabaj
approved these changes
Mar 21, 2019
ibolton336
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where an error is thrown and applications crash when there is null as value in one of
the table cells.
Fix #1371