Skip to content

Conversation

@priley86
Copy link
Member

What:
Discovered these were missed in #1227 today while testing downstream

ERROR in /Users/priley/GitHub/web-ui/frontend/public/components/factory/table.tsx(386,12):
TS2322: Type '{ children: Element[]; cells: any[]; rows: any; onSelect: (event: MouseEvent<Element>, isSelected...' is not assignable to type 'IntrinsicAttributes & TableProps & { children?: ReactNode; }'.
  Type '{ children: Element[]; cells: any[]; rows: any; onSelect: (event: MouseEvent<Element>, isSelected...' is not assignable to type 'TableProps'.
    Property 'bodyWrapper' is missing in type '{ children: Element[]; cells: any[]; rows: any; onSelect: (event: MouseEvent<Element>, isSelected...'.

do these work OK for now @suomiy or did you have something else in mind?

Additional issues:
none

@priley86 priley86 changed the title add bodyWrapper type add bodyWrapper type def Apr 22, 2019
@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://1829-pr-patternfly-react-patternfly.surge.sh

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #1829 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1829   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         606      606           
  Lines        6688     6688           
  Branches       76       76           
=======================================
  Hits         5535     5535           
  Misses       1123     1123           
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.49% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2076223...b26e293. Read the comment docs.

@atiratree
Copy link

This is passed directly to reactabular renderers which invoke React.CreateElement with that as a parameter. So the type should mirror https://reactjs.org/docs/react-api.html#createelement documentation I guess?

Extensions will probably have only the function type if HoC is used.

@redallen redallen merged commit ae27b14 into patternfly:master Apr 23, 2019
@priley86
Copy link
Member Author

Function is safe for now and avoids the ts error above, we can always iterate later though 😉

thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants