Skip to content

Conversation

@priley86
Copy link
Member

@priley86 priley86 commented Jun 13, 2019

What:
I noted in #1707 in OpenShift that our PF4 Grid Layout can be used to replace a BS3 Flexbox grid (or an emulation of that) in this scenario. We are deferring this in OpenShift for now until it can be done globally, but I am just updating the documentation here w/ best recommendation for anyone else.

  • note: also updates our Grid docs CSS selector here to be more specific so that pf-l-grid can be used without the dotted dash lines in other component examples)

Additional issues:

@priley86 priley86 changed the title chore(virtual-scroll): use pf4 css grid chore(virtual-scroll): use pf4 css grid layout for docs Jun 13, 2019
@patternfly-build
Copy link
Collaborator

PatternFly-React preview: https://2255-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #2255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2255   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files         669      669           
  Lines        8529     8529           
  Branches      734      734           
=======================================
  Hits         6814     6814           
  Misses       1362     1362           
  Partials      353      353
Flag Coverage Δ
#patternfly3 85.23% <ø> (ø) ⬆️
#patternfly4 74.92% <ø> (ø) ⬆️
#patternflymisc 95.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75ff23...355d0bf. Read the comment docs.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit a533058 into patternfly:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants