Skip to content

fix(react-table): Add exports for compoundExpand. #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 1 commit into from
Jul 22, 2019
Merged

fix(react-table): Add exports for compoundExpand. #2554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-table/src/components/Table/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ export { default as TableHeader, HeaderProps } from './Header';
export { default as TableBody, TableBodyProps } from './Body';
export { default as RowWrapper, RowWrapperRow, RowWrapperProps } from './RowWrapper';
export { default as ExpandableRowContent } from './ExpandableRowContent';
export { sortable, headerCol, cellWidth, ISortable, expandable, isRowExpanded } from './utils';
export { sortable, headerCol, cellWidth, ISortable, expandable, isRowExpanded, compoundExpand } from './utils';
Copy link
Contributor

@redallen redallen Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems close to export * from './utils';

Either way, the TS conversion in #2360 will eventually resolve this too.

Copy link
Member

@priley86 priley86 Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1... i am planning to circle back and ensure we can do export * on all exports, and that they are converted from default exports to named exports... will probably attempt this towards the end to be certain. I've gone ahead and rebased this change for now though!

export { SortByDirection } from './SortColumn';
1 change: 1 addition & 0 deletions packages/patternfly-4/react-table/src/components/Table/utils/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ export const headerCol: () => { component: string };
export const cellWidth: (width: string) => () => { className: string };
export const expandable: (value: ReactNode, extra: IExtra) => ReactNode;
export const isRowExpanded: (row: IRow, rows: Array<IRow>) => boolean | undefined;
export const compoundExpand: (value: ReactNode, extra: IExtra) => ISortable;