improvement(Select): Add showOnlySelectionCount property to Select component #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent to display only the sel Add showOnlySelectionCount property to Select component to display only the selection count rather than selection v 3456
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3457.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #3457 +/- ##
==========================================
- Coverage 67.09% 67.09% -0.01%
==========================================
Files 903 903
Lines 25471 25474 +3
Branches 2251 2252 +1
==========================================
+ Hits 17091 17092 +1
- Misses 7342 7343 +1
- Partials 1038 1039 +1
Continue to review full report at Codecov.
|
zherman0
reviewed
Jan 7, 2020
| {selections && (Array.isArray(selections) && selections.length > 0) && selectedChips} | ||
| {selections && showOnlySelectionCount && (Array.isArray(selections) && selections.length > 0) && ( | ||
| <div className={css(styles.selectToggleBadge)}> | ||
| <span className={css(badgeStyles.badge, badgeStyles.modifiers.read)}>{selections.length}</span> |
There was a problem hiding this comment.
Just curious, why did you not do <Badge isRead>{selections.length}</Badge> instead of using css classes?
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add showOnlySelectionCount property to Select component to display only the selection count rather than all selected values.
What: Closes ##3456
Additional issues: