fix(Dropdown): Set a random id for dropdown item if id is not given

[boaz0]

What: Closes #3549

//cc @jeff-phillips-18

[patternfly-build]

PatternFly-React preview: https://patternfly-react-pr-3555.surge.sh

[codecov-io]

Codecov Report

Merging #3555 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files         903      903           
  Lines       25502    25502           
  Branches     2262     2262           
=======================================
  Hits        17115    17115           
  Misses       7346     7346           
  Partials     1041     1041

Flag	Coverage Δ
#misc	95.45% <ø> (ø)	⬆️
#patternfly3	69.29% <ø> (ø)	⬆️
#patternfly4	64.21% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
...e/src/components/Dropdown/InternalDropdownItem.tsx	64.89% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327402f...128475e. Read the comment docs.

[jeff-phillips-18]

Could we simply not set the id if not given? So either remove the default props for id and componentId or, if linter doesn't allow it, then do:

id={id || undefined}

[boaz0]

@jeff-phillips-18 - yes, that makes more sense. Thanks for the feedback.

[jeff-phillips-18]

LGTM, thanks.

[dlabrecq]

Instead of setting this to null, couldn't we just not set a default? That is, remove this from defaultProps.

We shouldn't need to test componentID || undefined because it would already be undefined.

[jeff-phillips-18]

that was my thought as well, but if i recall the lint settings require optional props to have defaults, though undefined may be a valid default 🤷‍♂

[dlabaj]

yeah if you remove the default props here then it will just default to undefined and be fine.

[dlabaj]

Can you update this to no set a default for id and componentID, then you won't need the checks like dan suggested. Also title seems wrong for this PR seems. Thanks.

[dlabrecq]

LGTM

[jeff-phillips-18]

👍 Glad we got rid of the default value lint checks!