feat(dependencies): update to React 16 and Prettier 1.7#55
feat(dependencies): update to React 16 and Prettier 1.7#55priley86 merged 1 commit intopatternfly:masterfrom
Conversation
.vscode/settings.json
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
| // Place your settings in this file to overwrite default and user settings. | |||
There was a problem hiding this comment.
comments are not supported in json?
There was a problem hiding this comment.
it's weird that VSCode put these in mine by default. I can remove them..
package.json
Outdated
| "patternfly": "^3.27.4", | ||
| "prop-types": "^15.5.10", | ||
| "react": "^15.5.0" | ||
| "react": "^15.5.0 || ^16.0.0", |
There was a problem hiding this comment.
should we bump to 15.6.2? it will at least show deprecation warnings but will work?
There was a problem hiding this comment.
I am OK with either (as long as we can support downstreams). I will be trying to update all of my projects to 16 soon. Any thoughts on this version @jtomasek ?
There was a problem hiding this comment.
@ohadlevy I see why you are saying 15.6.2 now...from the release notes:
https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html
We've been serving React 16 to Facebook and Messenger.com users since earlier this year, and we released several beta and release candidate versions to flush out additional issues. With minor exceptions, if your app runs in 15.6 without any warnings, it should work in 16.
There was a problem hiding this comment.
I would not be so strict in terms of bumping peerDependencies as it forces the consuming apps to constantly update too. It definitely makes sense in case of React 16, although I'd keep 15.5.0 for now. TripleO UI is currently updating to 15.6.2 to get under MIT license. We won't be able to update for some time as we're currently hitting a few deprecation warnings on dependencies (Mostly Formsy-react which we're moving from towards redux-form).
waldenraines
left a comment
waldenraines
left a comment
There was a problem hiding this comment.
This all looks fine to me except for changes requested from other reviews so I'll mark this as 'request changes'.
priley86
force-pushed
the
react-16
branch
2 times, most recently
from
caba538 to
960e5a2
Compare
|
@ohadlevy @waldenraines @jtomasek one other thing i've noticed after looking at this again. I seem to be seeing subtle changes in the way Prettier is formatting the code from minor release to minor release, therefore I am locking the version at |
|
@priley86 locking the Prettier version should not be needed as it is locked in package-lock.yaml If some PR introduces unrelated prettier formating changes, it is caused by installing pf-react dependencies with older npm version than npm5 |
| "lint": "eslint --max-warnings 0 src storybook", | ||
| "prettier": | ||
| "prettier --write --single-quote --no-semi '{src,storybook}/**/*.js'", | ||
| "prettier": "prettier --write --single-quote --no-semi '{src,storybook}/**/*.js'", |
There was a problem hiding this comment.
Prettier now supports prettierrc config file, so we can extract some of these CLI options into it.
There was a problem hiding this comment.
@jtomasek we can add this in a future PR along with prettier-stylelint if you want. I have added prettierignore to prevent conflicts in package.json
There was a problem hiding this comment.
fwiw, i still <3 Prettier... i did some testing recently and found that it resolves over 40% of the Standard JS Lint rules automatically ;)
https://gist.github.com/priley86/78093a1f37b39242096c13ddfbe3f701
updates React/React DOM, React Bootstrap, and Storybook dependencies for React 16
|
@jtomasek reverted Prettier change for now. We just need to ensure people are using npm5/node8 or we will possibly see Prettier changes conflated. Also noted that Storybook 3.1.x is not compatible with React 16, however 3.2.x is (thus the updates there). |
4 participants
What:
updates React/React DOM dependency, React Bootstrap dependency, and Storybook dependency for React 16