feat(filter): update to latest patternfly designs #558
Conversation
|
I'm debating whether this should be a |
Pull Request Test Coverage Report for Build 2012
💛 - Coveralls |
| .filter-selected { | ||
| font-style: normal; | ||
| color: initial; | ||
| } |
There was a problem hiding this comment.
This belongs in patternfly core and should likely be .filter-pf-select-dropdown.filter-selected. The patternfly test pages show filters with selected categories and won't match patternfly-react if we only do this here.
There was a problem hiding this comment.
Ok, sounds good. What test pages though? I can't select anything here: https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/filter.html#
There was a problem hiding this comment.
that page shows the filter categories with selected items under the Category Filters
There was a problem hiding this comment.
Going to look at implementing these updates in PF core. Leaving this PR [WIP] until PF core changes are merged.
dtaylor113
changed the title
|
Waiting on https://github.com/patternfly/patternfly/pull/1137...it has merged |
dtaylor113
force-pushed
the
filter-updates
branch
4 times, most recently
from
4faa081 to
9429701
Compare
dtaylor113
changed the title
dtaylor113
force-pushed
the
filter-updates
branch
2 times, most recently
from
d6b4823 to
bdabe3c
Compare
| display: inline-block; | ||
|
|
||
| &>li { | ||
| & > li { |
There was a problem hiding this comment.
this file shouldn't need to be included, rebasing should resolve the issues
There was a problem hiding this comment.
? I changed this file to get rid of eslint warnings during builds.
There was a problem hiding this comment.
it has been fixed already
There was a problem hiding this comment.
ok, rebased, it did go away -thanks
dtaylor113
force-pushed
the
filter-updates
branch
from
bdabe3c to
f90ad7d
Compare
|
@priley86 do you have some time to review today? -thanks |
jeff-phillips-18
requested review from
jschuler
and removed request for
priley86
5 participants
What:
Updated the filter component to latest designs outlined here:
_compound-label.scss@mcarrano
Related PR: patternfly/patternfly-ng#449
Link to Storybook:
Storybook: Filter
Additional issues:
Fixes #553