Skip to content

fix(tooltip): change default entry and exit delay #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 3 commits into from
May 27, 2021
Merged

fix(tooltip): change default entry and exit delay #5746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d3b92d
fix(tooltip): change default entry and exit delay
redallen May 5, 2021
dfeedb3
check if children is a button or icon
redallen May 5, 2021
792d3b8
use 500ms per-design
redallen May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class CodeEditor extends React.Component<CodeEditorProps, CodeEditorState
downloadButtonToolTipText: 'Download',
copyButtonSuccessTooltipText: 'Content added to clipboard',
toolTipCopyExitDelay: 1600,
toolTipDelay: 100,
toolTipDelay: 300,
toolTipMaxWidth: '100px',
toolTipPosition: 'top',
customControls: null,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-code-editor/src/components/CodeEditor/CodeEditorControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ export const CodeEditorControl: React.FunctionComponent<CodeEditorControlProps>
className,
'aria-label': ariaLabel,
toolTipText,
exitDelay = 100,
entryDelay = 100,
exitDelay = 0,
entryDelay = 300,
maxWidth = '100px',
position = 'top',
onClick = () => {},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class ClipboardCopy extends React.Component<ClipboardCopyProps, Clipboard
position: TooltipPosition.top,
maxWidth: '150px',
exitDelay: 1600,
entryDelay: 100,
entryDelay: 300,
switchDelay: 2000,
onCopy: clipboardCopyFunc,
onChange: (): any => undefined,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export interface ClipboardCopyButtonProps

export const ClipboardCopyButton: React.FunctionComponent<ClipboardCopyButtonProps> = ({
onClick,
exitDelay = 100,
entryDelay = 100,
exitDelay = 0,
entryDelay = 300,
maxWidth = '100px',
position = 'top',
'aria-label': ariaLabel = 'Copyable input',
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const Tooltip: React.FunctionComponent<TooltipProps> = ({
isContentLeftAligned = false,
enableFlip = true,
className = '',
entryDelay = 0,
entryDelay = 300,
exitDelay = 0,
appendTo = () => document.body,
zIndex = 9999,
Expand Down
4 changes: 1 addition & 3 deletions packages/react-core/src/components/Tooltip/examples/Tooltip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,7 @@ import OutlinedQuestionCircleIcon from '@patternfly/react-icons/dist/js/icons/ou
<div>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam id feugiat augue, nec fringilla turpis.</div>
}
>
<span aria-label="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam id feugiat augue, nec fringilla turpis." tabIndex="0">
<OutlinedQuestionCircleIcon />
</span>
<OutlinedQuestionCircleIcon title="An icon with a tooltip" />
</Tooltip>
</div>
```
Expand Down
2 changes: 1 addition & 1 deletion packages/react-table/src/components/Table/TableText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const TableText: React.FunctionComponent<TableTextProps> = ({
variant = 'span',
wrapModifier = null,
tooltip: tooltipProp = '',
tooltipProps = { entryDelay: 1000 },
tooltipProps = {},
onMouseEnter: onMouseEnterProp = () => {},
...props
}: TableTextProps) => {
Expand Down